Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11643] Display profile picture only of users I have added to contacts #11650

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Jan 15, 2021

fixes #11643

image image

@flexsurfer flexsurfer requested a review from cammellos January 15, 2021 10:59
@flexsurfer flexsurfer self-assigned this Jan 15, 2021
@flexsurfer flexsurfer added this to the Release 1.10 milestone Jan 15, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Jan 15, 2021

Jenkins Builds

Click to see older builds (9)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8e6a86e #1 2021-01-15 11:14:38 ~14 min android 📦apk 📲
✔️ 8e6a86e #1 2021-01-15 11:14:42 ~14 min android-e2e 📦apk 📲
✔️ 8e6a86e #1 2021-01-15 11:19:20 ~19 min ios 📦ipa 📲
✔️ 60d3203 #2 2021-01-15 12:29:56 ~11 min android-e2e 📦apk 📲
✔️ 60d3203 #2 2021-01-15 12:29:59 ~11 min android 📦apk 📲
✔️ 60d3203 #2 2021-01-15 12:40:34 ~21 min ios 📦ipa 📲
✔️ ed1988f #3 2021-01-15 13:03:15 ~13 min android-e2e 📦apk 📲
✔️ ed1988f #3 2021-01-15 13:03:39 ~13 min android 📦apk 📲
✔️ ed1988f #3 2021-01-15 13:11:37 ~21 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 729c36f #4 2021-01-15 13:32:53 ~11 min android 📦apk 📲
✔️ 729c36f #4 2021-01-15 13:32:59 ~11 min android-e2e 📦apk 📲
✔️ 729c36f #4 2021-01-15 13:36:36 ~14 min ios 📦ipa 📲
✔️ a89f2a5 #5 2021-01-18 08:32:16 ~9 min android-e2e 📦apk 📲
✔️ a89f2a5 #5 2021-01-18 08:37:24 ~14 min android 📦apk 📲
✔️ a89f2a5 #5 2021-01-18 08:40:07 ~16 min ios 📦ipa 📲

@churik churik self-assigned this Jan 15, 2021
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 92
Failed tests: 1
Passed tests: 91
IDs of failed tests: 5332 

Failed tests (1)

Click to expand
1. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332

Device 1: Tap on StartNewChatButton
Device 1: Wait for UserNameBelowNewChatButton

3-random username is not resolved in chat input after selecting it in mention suggestions list by nickname! Nickname is not resolved on send message

Device sessions

Passed tests (91)

Click to expand
1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions

2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions

3. test_send_eth_from_wallet_to_address, id: 5308
Device sessions

4. test_onboarding_screen_when_requesting_tokens_for_recovered_account, id: 5677
Device sessions

5. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions

6. test_text_message_1_1_chat, id: 5305
Device sessions

7. test_push_notification_1_1_chat, id: 6283
Device sessions

8. test_delete_chats_via_delete_button, id: 5387
Device sessions

9. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions

10. test_open_public_chat_using_deep_link, id: 5396
Device sessions

11. test_offline_add_new_group_chat_member, id: 3998
Device sessions

12. test_copy_contact_code_and_wallet_address, id: 5375
Device sessions

13. test_add_account_to_multiaccount_instance_private_key, id: 6272
Device sessions

14. test_mobile_data_usage_popup_continue_syncing, id: 5741
Device sessions

15. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions

16. test_delete_close_all_tabs, id: 5390
Device sessions

17. test_create_new_group_chat, id: 3994
Device sessions

18. test_messaging_in_different_networks, id: 5338
Device sessions

19. test_send_token_with_7_decimals, id: 5350
Device sessions

20. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions

21. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device sessions

22. test_block_user_from_public_chat, id: 5786
Device sessions

23. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions

24. test_ens_username_recipient, id: 5406
Device sessions

25. test_keycard_send_eth_to_ens (TestRail link is not found)
Device sessions

26. test_send_non_english_message_to_newly_added_contact, id: 5315
Device sessions

27. test_switch_users_and_add_new_account, id: 5356
Device sessions

28. test_mobile_data_usage_popup_stop_syncing, id: 6228
Device sessions

29. test_open_transaction_on_etherscan, id: 5384
Device sessions

30. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions

31. test_request_public_key_status_test_daap, id: 5397
Device sessions

32. test_sign_message_from_daap, id: 5342
Device sessions

33. test_back_forward_buttons_browsing_website, id: 5321
Device sessions

34. test_account_recovery_with_uppercase_recovery_phrase_logcat, id: 5394
Device sessions

35. test_redirect_to_public_chat_tapping_tag_message, id: 5675
Device sessions

36. test_keycard_send_two_transactions_one_after_another_in_dapp, id: 6288
Device sessions

37. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions

38. test_long_press_to_delete_chat, id: 5319
Device sessions

39. test_copy_and_paste_messages, id: 5317
Device sessions

40. test_unread_messages_counter_public_chat, id: 5360
Device sessions

41. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device sessions

42. test_transaction_wrong_password_wallet, id: 5408
Device sessions

43. test_user_can_switch_network, id: 5299
Device sessions

44. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions

45. test_send_two_transactions_one_after_another_in_dapp, id: 5744
Device sessions

46. test_mobile_data_usage_settings, id: 6229
Device sessions

47. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions

48. test_add_to_contacts, id: 5316
Device sessions

49. test_fetch_more_history_in_empty_chat, id: 6205
Device sessions

50. test_install_pack_and_send_sticker, id: 5782
Device sessions

51. test_keycard_send_two_transactions_in_batch_in_dapp, id: 6287
Device sessions

52. test_keycard_sign_message_from_daap, id: 6251
Device sessions

53. test_manage_assets, id: 5341
Device sessions

54. test_send_two_transactions_in_batch_in_dapp, id: 5743
Device sessions

55. test_timestamp_in_chats, id: 5385
Device sessions

56. test_browser_managing_bookmarks, id: 6633
Device sessions

57. test_request_stt_from_daap, id: 5309
Device sessions

58. test_send_emoji, id: 5328
Device sessions

59. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions

60. test_dapps_permissions, id: 5738
Device sessions

61. test_open_chat_by_pasting_public_key, id: 5304
Device sessions

62. test_login_with_new_account_logcat, id: 5312
Device sessions

63. test_send_eth_to_ens_in_chat, id: 6279
Device sessions

64. test_open_blocked_secure_not_secure_sites, id: 6210
Device sessions

65. test_wallet_set_up, id: 5335
Device sessions

66. test_send_transaction_with_custom_token, id: 6208
Device sessions

67. test_home_view, id: 5379
Device sessions

68. test_can_add_existing_ens, id: 5502
Device sessions

69. test_logcat_backup_recovery_phrase, id: 5419
Device sessions

70. test_offline_is_shown_messaging_1_1_chat, id: 5310
Device sessions

71. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions

72. test_need_help_section, id: 5391
Device sessions

73. test_send_eth_in_1_1_chat, id: 6253
Device sessions

74. test_refresh_button_browsing_app_webview, id: 5354
Device sessions

75. test_collectible_from_wallet, id: 5346
Device sessions

76. test_public_chat_messaging, id: 5313
Device sessions

77. test_keycard_request_stt_from_daap, id: 6249
Device sessions

78. test_add_account_to_multiaccount_instance_seed_phrase, id: 6271
Device sessions

79. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions

80. test_add_new_keycard_account_and_login, id: 5689
Device sessions

81. test_pass_phrase_validation, id: 5363
Device sessions

82. test_send_and_open_links, id: 5373
Device sessions

83. test_share_contact_code_and_wallet_address, id: 5323
Device sessions

84. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions

85. test_ens_mentions_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions

86. test_can_see_all_transactions_in_history, id: 5314
Device sessions

87. test_public_chat_clear_history, id: 5386
Device sessions

88. test_reactions_to_message_in_chats, id: 6315
Device sessions

89. test_filters_from_daap, id: 5353
Device sessions

90. test_fetching_balance_after_offline, id: 6237
Device sessions

91. test_keycard_fetching_balance_after_offline, id: 6290
Device sessions

@flexsurfer flexsurfer force-pushed the feature/profile-pic-visibility branch 2 times, most recently from 60d3203 to ed1988f Compare January 15, 2021 12:49
@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions

@flexsurfer flexsurfer force-pushed the feature/profile-pic-visibility branch from ed1988f to 729c36f Compare January 15, 2021 13:21
@churik
Copy link
Member

churik commented Jan 15, 2021

@flexsurfer thank you!
remaining issues:

ISSUE 1: can't see own profile picture in group info

IMAGE 2021-01-15 16:45:03
regardess of "Show profile pictures of" in settings

ISSUE 2: after updating profile picture it is not updated for users who doesn't add him as contact

Steps:

  1. User A: set profile picture 1, post something to public chat
  2. User A: set profile picture 2
  3. User B: join public chat, set "Show profile pictures of" to "Everyone", check public chat

Expected result:
picture 2 for User A
Actual result:
picture 1 for User A
OS: IOS, Android

May be it is acceptable for now, let me know @flexsurfer @cammellos

@cammellos
Copy link
Contributor

Issue 2 does not seem to be related to this changes, thought I can't be 100% sure, can you replicate consistently?

@churik
Copy link
Member

churik commented Jan 15, 2021

@cammellos yes, I can. And you are right - it is not related, as it is reproducible on nightly, so will report it separately (if it makes sense in general)
so only issue 1 is remaining

@cammellos
Copy link
Contributor

cammellos commented Jan 15, 2021 via email

@churik
Copy link
Member

churik commented Jan 15, 2021

@cammellos yes, profile picture will remain old until:

  1. user with updated image will post smth in public chat
  2. or you add him to contacts
    (and maybe there are some other ways to get it updated)

@cammellos
Copy link
Contributor

@churik that's the expected behavior actually, we won't update pictures in public chat until you post, for privacy and bw reasons
it's a bit unexpected, but it's how we thought about it :)

@flexsurfer flexsurfer force-pushed the feature/profile-pic-visibility branch from 729c36f to a89f2a5 Compare January 18, 2021 08:22
@flexsurfer
Copy link
Member Author

fixed group chat, although it is not introduced in this PR

@churik
Copy link
Member

churik commented Jan 18, 2021

Ready to be merged in 1.10, thank you!

@flexsurfer flexsurfer force-pushed the feature/profile-pic-visibility branch from a89f2a5 to 329182f Compare January 18, 2021 09:14
@flexsurfer flexsurfer merged commit 329182f into develop Jan 18, 2021
@flexsurfer flexsurfer deleted the feature/profile-pic-visibility branch January 18, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Display profile picture only of users I have added to contacts
4 participants