-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11643] Display profile picture only of users I have added to contacts #11650
Conversation
Jenkins BuildsClick to see older builds (9)
|
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (91)Click to expand
|
60d3203
to
ed1988f
Compare
100% of end-end tests have passed
Passed tests (1)Click to expand
|
ed1988f
to
729c36f
Compare
@flexsurfer thank you! ISSUE 1: can't see own profile picture in group info
ISSUE 2: after updating profile picture it is not updated for users who doesn't add him as contactSteps:
Expected result: May be it is acceptable for now, let me know @flexsurfer @cammellos |
Issue 2 does not seem to be related to this changes, thought I can't be 100% sure, can you replicate consistently? |
@cammellos yes, I can. And you are right - it is not related, as it is reproducible on nightly, so will report it separately (if it makes sense in general) |
what abou 1.10, same issue?
…On Fri, Jan 15, 2021, 17:20 Tetiana Churikova ***@***.***> wrote:
@cammellos <https://github.com/cammellos> yes, I can. And you are right -
it is not related, as it is reproducible on nightly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11650 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHYJMBLMI664PSHPEJ2HT3S2BTLNANCNFSM4WD4HTLA>
.
|
@cammellos yes, profile picture will remain old until:
|
@churik that's the expected behavior actually, we won't update pictures in public chat until you post, for privacy and bw reasons |
729c36f
to
a89f2a5
Compare
fixed group chat, although it is not introduced in this PR |
Ready to be merged in 1.10, thank you! |
Signed-off-by: andrey <[email protected]>
a89f2a5
to
329182f
Compare
fixes #11643